-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to packaging 0.22 #36
Comments
Re: "it removes the dependency on pyparsing": two micropip tests currently assume micropip/tests/test_micropip.py Line 235 in d02734b
micropip/tests/test_micropip.py Lines 337 to 343 in d02734b
|
Great news! 🎉 |
Yes, thanks @mentalisttraceur we would have to adapt those tests not to use pyparsing. |
This was fixed upstream, but we would need to wait for the 0.22.1 or 0.23.0 release |
@rth When can we expect the 0.22.1 or 0.23.0 release? |
We will release 0.22.1 when we address most of the bugs that are reported in 0.22.0. |
Packaging v22.0 is released and we should upgrade to it. In particular, it removes the dependency on pyparsing which is great.
Currently, it doesn't work due to a regression in pypa/packaging#638 so we either need to wait for a new release with a fix, or patch
micropip/micropip/externals/pip/_vendor/pkg_resources.py
Line 417 in e33b73b
but patching the vendored version of
pkg_resources
is not great, because it means the extra argument to pass there depends on thepackaging
version (which can be different inside and outside Pyodide VM). So waiting for an upstream fix would be preferable.The text was updated successfully, but these errors were encountered: