-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review pyomeca: future directions #105
Comments
We would like to thank you for those kind words.
While these features may seem basic, they remain necessary and useful in the daily workflow of a biomechanical researcher.
We have some ideas for functions that could extend pyomeca, particularly concerning the construction of kinematic models such as algorithms to find axes/centre of rotation or joint angles.
We agree and we plan to add more "high-level" modules that extract clinical variables.
We are indeed developing several libraries in parallel with As such, we:
As opposed to a more monolithic design, the benefits of this approach are:
Let's take our For this reason, rather than developing a massive biomechanics library, we have several small libraries that are interdependent as show in the following figure: As we mentioned in the previous paragraph, |
Hi @romainmartinez, Thanks a lot for your detailed response. I agree with you and I like your arguments. Please iterate over the manuscript one more time and include some of the points in your response. In particular, please improve the statement of need mentioning your response to the question:
In the summary, you can include your philosophy on having simple and powerful modules that are modular and easy to develop. If you agree, it would be nice to have a conclusion section where you will outline your vision for this project and how it might evolve. It would be nice to mention how pyomeca will interact with other modules such as pyosim or biorbd-viz. Thanks! |
Dear authors,
Thanks a lot for the excelent documentation and setting up everything in accordance with the software best practices.
I want to better understand your future directions and vision about this project.
The API and the use cases seem nice, however, in terms of added value it does not bring much to the user except basic operations such as reading, writing, filtering and plotting. I would find it very useful, if this framework goes a step forward and provide functions for processing and extracting meaningful clinical outputs from the raw data. For example, it would be very nice if you provide common utilities for extracting the kinematics and kinetics ensembles per gait cycle, or calculate cadence, speed, etc.
On the other hand, by looking at the repositories under pyomeca it seems that you are working on some nice packages that try to manipulate c3d files or interface with OpenSim. Is pyomeca only related to the features that were described in the publication or is it going to be something bigger where you will provide additional modules in the future? Please indicate your vision about this project and things you plan to support in the future. Are the projects under pyomeca intended for this publication or they will be published in the future?
The text was updated successfully, but these errors were encountered: