Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forceplates and floor displayed with c3d #25

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented May 22, 2024

@mickaelbegon


This change is Reviewable

import rerun as rr
from pyomeca import Markers as PyoMarkers

from .phase_rerun import PhaseRerun


def rrc3d(c3d_file: str) -> None:
def rrc3d(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function rrc3d has 5 arguments (exceeds 4 allowed). Consider refactoring.

import rerun as rr
from pyomeca import Markers as PyoMarkers

from .phase_rerun import PhaseRerun


def rrc3d(c3d_file: str) -> None:
def rrc3d(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function rrc3d has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Copy link

codeclimate bot commented May 22, 2024

Code Climate has analyzed commit b7dea39 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@Ipuch Ipuch merged commit 42d9881 into pyomeca:main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant