Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProjectBuilder.srcdir should not be public #396

Open
FFY00 opened this issue Oct 25, 2021 · 1 comment
Open

ProjectBuilder.srcdir should not be public #396

FFY00 opened this issue Oct 25, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@FFY00
Copy link
Member

FFY00 commented Oct 25, 2021

I was just looking at the code and noticed that ProjectBuilder.srcdir is public, but we are not prepared to deal with value changes.

We should make it private. We can reconsider which attributes to make public in the future, but for now let's keep it private.
@FFY00 FFY00 added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 25, 2021
@layday
Copy link
Member

layday commented Oct 25, 2021

I have made it read-only in #361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FFY00 @layday