Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Quote individual dependencies in the list logged to console #617

Closed
webknjaz opened this issue May 14, 2023 · 3 comments
Closed

[UX] Quote individual dependencies in the list logged to console #617

webknjaz opened this issue May 14, 2023 · 3 comments

Comments

@webknjaz
Copy link
Member

See

* Installing packages in isolated environment... (Cython, expandvars, setuptools-scm-git-archive >= 1.1; python_version < '3.7', setuptools-scm[toml] >= 3.5, < 7.0; python_version < '3.7', setuptools-scm[toml] >= 7.0; python_version >= '3.7', setuptools>=45, toml)

There's a few dependencies that are conditional on environment and/or have complex version specifiers. In it, a comma is use in two contexts — as a package request separator and as a separator of parts of a version specifier. This is something an inexperienced individual could easily get confused about when reading the logs.

I think that these deps should be repr()ed or smth similar for clarity.

@layday
Copy link
Member

layday commented Nov 20, 2023

PR improving the CLI output welcome :)

@webknjaz
Copy link
Member Author

webknjaz commented Dec 23, 2023

It seems like here's a PR now: #711. UPD: that PR got stalled and subsequently closed. There was a suggestion to go for a multi-line list instead of quoting the entries that a new PR author should implement — #711 (comment).

@layday
Copy link
Member

layday commented Mar 6, 2024

Addressed in #749.

@layday layday closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants