Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warning when building macOS arm64 wheels #1312

Merged
merged 2 commits into from Oct 21, 2022
Merged

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Oct 14, 2022

When MACOSX_DEPLOYMENT_TARGET is not set by the user, cibuildwheel always defaults to 10.9. This leads to a warning when building arm64 wheels.
This commit removes the warning by setting the default to 11.0 for arm64 builds.

Reported in #1300 (comment)

When `MACOSX_DEPLOYMENT_TARGET` is not set by the user, cibuildwheel always defaults to `10.9`.
This leads to warning when building arm64 wheels.
This commit removes the warning by setting the default to `11.0` for arm64 builds.
@mayeut
Copy link
Member Author

mayeut commented Oct 14, 2022

I chose to add the test in an existing one not increase test time.
I chose to test both stdout & stderr streams on purpose even if, today, it's on stderr.
I was a bit hesitant to check for a shorter string. If the string changes, the test won't be doing anything useful & maybe just checking for warning is better even if not targeted (thus could report unrelated warnings in the future).

@joerick
Copy link
Contributor

joerick commented Oct 16, 2022

@mayeut i hope it's okay I added another test to this, just checking that the warning is detected by forcing it to be produced with a MACOSX_DEPLOYMENT_TARGET=10.8. It's only a 5s test.

@joerick joerick merged commit 1140a0c into pypa:main Oct 21, 2022
23 checks passed
@mayeut mayeut deleted the fix-mdt-arm64 branch October 21, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants