Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test with Python 3.11 #1300

Merged
merged 4 commits into from Oct 26, 2022
Merged

chore: test with Python 3.11 #1300

merged 4 commits into from Oct 26, 2022

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Oct 9, 2022

With 3.11.0 available in roughly a couple weeks, let's start testing as draft.
I will update this once 3.11 reaches GA.

@henryiii
Copy link
Contributor

henryiii commented Oct 9, 2022

3.11 as max needs to be specified in pre-commit setup-cfg-fmt.

@mayeut
Copy link
Member Author

mayeut commented Oct 9, 2022

3.11 as max needs to be specified in pre-commit setup-cfg-fmt.

just read the docs of setup-cfg-fmt and saw that.

I won't bother to change this & will wait for 3.11 GA at which point, setup-cfg-fmt should be updated (or I'll do it then).
The important part is to check everything is working with 3.11 (no obvious reason why not but at least we'll know for sure).

@henryiii
Copy link
Contributor

I bumped it - it won't automatically update, the automatic classifier feature was removed from setup-cfg-fmt (I do prefer the explicit limit, though IMO this was one of the best features of setup-cfg-fmt).

@henryiii
Copy link
Contributor

IMO, this is ready to go in any time - I'd really like the trove classifier, since we support producing 3.11 wheels. Ideally, we should also be able to run on 3.11, and we can.

FYI, are we checking to make sure MACOSX_DEPLOYMENT_TARGET is set to a lower value (10.9) than the version on which the Python interpreter was compiled never shows up in our integration tests? Looks like it's showing up in https://github.com/mypyc/mypy_mypyc-wheels/actions/runs/3245210848/jobs/5322448904 (on all Pythons, actually).

@mayeut
Copy link
Member Author

mayeut commented Oct 14, 2022

IMO, this is ready to go in any time - I'd really like the trove classifier, since we support producing 3.11 wheels. Ideally, we should also be able to run on 3.11, and we can.

I would have liked for the action to be tested on 3.11 as well before getting this in (& remove the ~3.11.0-0 specifier) but fair enough, it can probably be merged in as-is.

FYI, are we checking to make sure...

I'm almost sure we don't & I think this was discussed in the past.

@mayeut mayeut marked this pull request as ready for review October 14, 2022 07:03
@joerick
Copy link
Contributor

joerick commented Oct 26, 2022

Any last changes on this now that 3.11 is released? It would be neat to get it in before the next cibuildwheel release with 3.11-final.

.github/workflows/test.yml Outdated Show resolved Hide resolved
@joerick joerick merged commit 8672fee into pypa:main Oct 26, 2022
23 checks passed
@mayeut mayeut deleted the gha-3.11 branch October 27, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants