Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few types to keep pyright happy #1494

Merged
merged 1 commit into from
May 9, 2023
Merged

Fix a few types to keep pyright happy #1494

merged 1 commit into from
May 9, 2023

Conversation

joerick
Copy link
Contributor

@joerick joerick commented May 8, 2023

I use VS Code and it doesn't like these unspecified Final types, so I'm specifying fully to get rid of the red squigglies.

henryiii
henryiii approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve noticed this too and update them when I notice it.

@joerick joerick merged commit 4b88d36 into main May 9, 2023
@joerick joerick deleted the fixpyright branch May 9, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Czaki Czaki Czaki approved these changes

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joerick @Czaki @henryiii