-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PowerShell 7.3 in GHA #1741
Conversation
Fixes compatibility with PowerShell 7.3 on Windows through GitHub Actions when one of the options for cibuildwheel is empty.
I've used pythongssapi/python-gssapi#342 to test out these changes.
Both work with the changes in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for a quick fix. Hopefully in a few months everyone will be on 7.3+ and we can simply this to look much more like the bash version, getting rid of the weird double quoting finally.
I would assume you would still want this fix due to self hosted runners that might be running with 7.2. 7.2 EOL is November 8th 2024 https://learn.microsoft.com/en-us/powershell/scripting/install/powershell-support-lifecycle?view=powershell-7.4#powershell-end-of-support-dates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick PR. I guess we want to get this out pretty quick if the Windows image update rollout is gonna break everyone.
Thanks for the reviews! |
I'd probably not bother to remove this workaround until 2025 or so. Just nice to think we can eventually remove it. |
Fixes compatibility with PowerShell 7.3 on Windows through GitHub Actions when one of the options for cibuildwheel is empty.
I'm not sure how you want to go about this but I believe this should solve the issue with the migration of GHA to PowerShell 7.4 that is happening now.
Fixes: #1740