The executable bit is lost for scripts in data directory

[frostming]

installer seems only to copy streams and won't copy the executable bit when installing

[FFY00]

Oh, right, because we only work with streams for the abstraction. We will have to add something for the permissions/mode. Do we need this in anything other than the user-provided scripts? If not, would it be reasonable to simply set the executable on all installed scripts?

[FFY00]

Nevermind, users can ship executables as package resources 😅

[pradyunsg]

Got an example zip file for this?

[uranusjr]

No example but this is where pip handles the permission bits.

https://github.com/pypa/pip/blob/0f21fb920647f07439c3ec9fb29579c0e00072ec/src/pip/_internal/operations/install/wheel.py#L656-L663

https://github.com/pypa/pip/blob/0f21fb920647f07439c3ec9fb29579c0e00072ec/src/pip/_internal/utils/unpacking.py#L43-L47

[pradyunsg]

Ah, this is the stuff that is missing:

https://github.com/pypa/pip/blob/0f21fb920647f07439c3ec9fb29579c0e00072ec/src/pip/_internal/utils/unpacking.py#L88

https://github.com/pypa/pip/blob/0f21fb920647f07439c3ec9fb29579c0e00072ec/src/pip/_internal/utils/unpacking.py#L96

[pradyunsg]

I've got a patch for this in pradyunsg@d2cd484, since I wrote that as part of #74. Gonna split that out though, since that's unrelated to that broader PR.