pip install from git url doesn't honour setup.cfg

[dvarrazzo]

Trying to install psycopg from a git url fails in an apparently mysterious way:

$ pip install --verbose -e git+https://github.com/psycopg/psycopg2.git#egg=psycopg2
[...]
gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -DHAVE_MXDATETIME=1 -DPSYCOPG_DEFAULT_PYDATETIME=1 -DPSYCOPG_VERSION="2.6.dev0 (dt dec mx pq3 ext)" -DPG_VERSION_HEX=0x090303 -DPG_VERSION_HEX=0x090303 -I/usr/include/python2.7/mx -I/usr/include/python2.7 -I. -I/usr/include/postgresql -I/usr/include/postgresql/9.3/server -c psycopg/connection_type.c -o build/temp.linux-x86_64-2.7/psycopg/connection_type.o -Wdeclaration-after-statement -Wdeclaration-after-statement
psycopg/connection_type.c:1041:5: error: ‘psyco_conn_get_exception’ undeclared here (not in a function)
Complete output from command /home/piro/.virtualenvs/tmp/bin/python -c "import setuptools, tokenize; __file__='/home/piro/.virtualenvs/tmp/src/psycopg2/setup.py'; exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" develop --no-deps:

The reason of the failure is apparently that the gcc command line is missing a few declarations that are defined in the setup.cfg. Installing by any other mean (downloading or just with pip install psycopg2) also adds the following declarations to the command line:

-DPSYCOPG_EXTENSIONS=1 -DPSYCOPG_NEW_BOOLEAN=1 -DHAVE_PQFREEMEM=1

If you suggest an acceptable way to work around this problem fixing the setup.py we'd be happy to implement it in psycopg.

Tested pip version is 1.5.2

[Ivoz]

Could you say what version setuptools you are using? I believe this might be a bug where it is not reading your project's setup.cfg when doing an editable install.

Pip never does any of the actual installing, it tells setuptools to.

[dvarrazzo]

Maybe 0.6.24? Not sure as:

In [1]: import setuptools

In [2]: setuptools
Out[2]: <module 'setuptools' from '/home/piro/.virtualenvs/tmp/local/lib/python2.7/site-packages/distribute-0.6.24-py2.7.egg/setuptools/__init__.pyc'>

In [3]: setuptools.__version__
Out[3]: '0.6'

[Ivoz]

Firstly, you may like to check whether a setup.cfg exists in your current directory, as it may override the project's setup.cfg.

This may be a legimate bug in distribute 0.6.24 (virtually unmaintained now), however you might like to try as a workaround upgrading to newer versions of the packaging tools. I'm on windows atm, so can't test compiling, but to upgrade them on your system would want to run

$ [sudo] pip install -U pip setuptools virtualenv

(outside a virtualenv), you could even just update your particular virtualenv's copies of pip & setuptools inside that environment, i.e

$ pip install -U pip setuptools

If this behaviour is still present using the newest tools then this might be considered a bug in setuptools.

[dvarrazzo]

Tested with pip 1.5.4, setuptools 3.1, virtualenv 1.11.4: same problem.

This is enough to reproduce:

mkvirtualenv testpip
pip install -U pip setuptools virtualenv
pip install --verbose -e git+https://github.com/psycopg/psycopg2.git#egg=psycopg2

[dvarrazzo]

I've worked around this bug by passing manually the defines found in the setup.cfg to the Extension (reading the cfg files works ok in the setup.py: it's the Extension object that doesn't receive them).

If you want to test please use an older commit, for instance:

pip install -e git+https://github.com/psycopg/psycopg2.git@maint_2_4#egg=psycopg2

[dstufft]

Closing this, if it continues to happen please reopen this issue or open a new one with reproduction steps, however at this time I cannot reproduce this even with older commit.

[dvarrazzo]

It seems working fine as of pip 9.0.1, setuptools 34.3.2, virtualenv 15.1.0, thank you.