Blacken src/pip/_internal/commands/ #10192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progresses the black formatting of the codebase further.
In Python 3.6+, `dict` is ordered now and we can use that.
This is suboptimal behaviour in black that'll hopefully get fixed in the near future.
Black seems to still get confused about where it should break up multi-part if statements.
This looks better IMO.
This is singlehandedly the most satisfying part of all the formatting efforts.
pradyunsg
added
the
skip news
|
This PR encapsulates how I feel about black: the consistency is amazing. Some of the choices are ones I can grow into. And, on a fairly low frequency, it will definitely make me go "hmm... no". :) |
|
FYI: These PRs are easiest to review on a side-by-side diff. |
|
I'm gonna be optimistic and say that there's no concerns with this specific PR, which is why it's got no comments. 😉 Merging, since reverts are cheap! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #8543 further.