Refactor the freeze command #10410
Merged
Refactor the freeze command #10410
+20
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs rebase or merge
sbidoul
force-pushed
the
refactor-freeze-sbi
branch
from
d595aae
to
f39a639
Compare
github-actions
bot
added
the
needs rebase or merge
sbidoul
force-pushed
the
refactor-freeze-sbi
branch
from
f39a639
to
1739e43
Compare
pradyunsg
reviewed
Sep 21, 2021
news/10410.feature.rst
Outdated
| @@ -0,0 +1,2 @@ | |||
| Allways fallback to reporting the editable project location when pip freeze | |||
There was a problem hiding this comment.
typo:
Suggested change
| Allways fallback to reporting the editable project location when pip freeze | |
| Always fallback to reporting the editable project location when pip freeze |
There was a problem hiding this comment.
nit-ish: I would rephrase this to something like:
pip freezewill now ...
I find it easier to skim, when we mention the "thing-that-we-affected" at the start of the message.
| else: | ||
| # name==version requirement | ||
| req = _format_as_name_version(dist) | ||
| comments = [] |
There was a problem hiding this comment.
nit: I'd put this at the start of the else.
pradyunsg
approved these changes
Sep 21, 2021
DiddiLeija
approved these changes
Sep 21, 2021
At the beginning this function returns if not dist.editable. So returning editable=False after that does not make sense. Return an editable with the file system location instead when there is any issue getting VCS information.
It is always true.
sbidoul
force-pushed
the
refactor-freeze-sbi
branch
from
1739e43
to
6ac3ffe
Compare
pradyunsg
approved these changes
Sep 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to and sits on top of #10249.
This slightly changes the output of pip freeze in case the detection of the VCS reference of an editable install fails.
Before it returned a non editable requirement in some VCS error situations.
Now it always returns an editable requirement, but pointing to the local directory when the VCS could not be determined for any reason.
This is more consistent, avoids information loss, and greatly simplifies the logic.