New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added subdirectory editable option, small refactoring. #1082

Merged
merged 7 commits into from Oct 6, 2013

Conversation

Projects
None yet
5 participants
@niedbalski
Contributor

niedbalski commented Jul 24, 2013

  • Small refactoring on pip/req.py.
  • Added _strip_postfix, _build_req_from_url, _build_editable_options functions.
  • Added test for install a package from a subdirectory.
Show outdated Hide outdated pip/req.py Outdated
@niedbalski

This comment has been minimized.

Show comment
Hide comment
@niedbalski

niedbalski Jul 25, 2013

Contributor

Hey @pnasrat , merge?

Contributor

niedbalski commented Jul 25, 2013

Hey @pnasrat , merge?

@freyes

This comment has been minimized.

Show comment
Hide comment
@freyes

freyes Aug 8, 2013

This is a pretty useful feature for my current use case, we have a single repository for several python packages, the layout looks like this:

foo_pkg
  setup.py
bar_pkg
  setup.py

Being foo and bar python packages., it would be great to install them using pip.

freyes commented Aug 8, 2013

This is a pretty useful feature for my current use case, we have a single repository for several python packages, the layout looks like this:

foo_pkg
  setup.py
bar_pkg
  setup.py

Being foo and bar python packages., it would be great to install them using pip.

@pnasrat

This comment has been minimized.

Show comment
Hide comment
@pnasrat

pnasrat Aug 12, 2013

Contributor

Sorry been caught up with life stuff - can you make sure this is mergable then I'll take another look.

Contributor

pnasrat commented Aug 12, 2013

Sorry been caught up with life stuff - can you make sure this is mergable then I'll take another look.

@niedbalski

This comment has been minimized.

Show comment
Hide comment
@niedbalski

niedbalski Aug 12, 2013

Contributor

Hey @pnasrat:

Synced changes from upstream. Ready to merge.

Contributor

niedbalski commented Aug 12, 2013

Hey @pnasrat:

Synced changes from upstream. Ready to merge.

@davehunt

This comment has been minimized.

Show comment
Hide comment
@davehunt

davehunt Aug 14, 2013

+1 for this awesome feature!

davehunt commented Aug 14, 2013

+1 for this awesome feature!

"""
Strip req postfix ( -dev, 0.2, etc )
"""
## FIXME: use package_to_requirement?

This comment has been minimized.

@pnasrat

pnasrat Aug 14, 2013

Contributor

Out of curiosity what's stopping you use that? Not a blocker from me but just curious

@pnasrat

pnasrat Aug 14, 2013

Contributor

Out of curiosity what's stopping you use that? Not a blocker from me but just curious

This comment has been minimized.

@pnasrat

pnasrat Aug 14, 2013

Contributor

Oh I see it's an extracted method keeping the original comment.

@pnasrat

pnasrat Aug 14, 2013

Contributor

Oh I see it's an extracted method keeping the original comment.

@pnasrat

This comment has been minimized.

Show comment
Hide comment
@pnasrat

pnasrat Aug 14, 2013

Contributor

+1 from me @qwcode @hltbra @pfmoore happy for this to get merged?

Contributor

pnasrat commented Aug 14, 2013

+1 from me @qwcode @hltbra @pfmoore happy for this to get merged?

@pnasrat

This comment has been minimized.

Show comment
Hide comment
@pnasrat

pnasrat Aug 20, 2013

Contributor

I think this is pretty much ready but can you:

Add a description of the change to CHANGES.txt and also add documentation for the feature in docs/usage.rst

Contributor

pnasrat commented Aug 20, 2013

I think this is pretty much ready but can you:

Add a description of the change to CHANGES.txt and also add documentation for the feature in docs/usage.rst

@niedbalski

This comment has been minimized.

Show comment
Hide comment
@niedbalski

niedbalski Aug 20, 2013

Contributor

@pnasrat done.

Contributor

niedbalski commented Aug 20, 2013

@pnasrat done.

@niedbalski

This comment has been minimized.

Show comment
Hide comment
@niedbalski

niedbalski Sep 9, 2013

Contributor

Hey @pnasrat, any news on this merge?

Contributor

niedbalski commented Sep 9, 2013

Hey @pnasrat, any news on this merge?

@pnasrat

This comment has been minimized.

Show comment
Hide comment
@pnasrat

pnasrat Sep 10, 2013

Contributor

Sorry I missed the last few updates in my inbox for this bug somehow. It looks like it's not mergable atm. I know this has taken longer than I like if you have time to get it mergable now do it and I'll merge otherwise I can try pull and fix up myself on the weekend.

Contributor

pnasrat commented Sep 10, 2013

Sorry I missed the last few updates in my inbox for this bug somehow. It looks like it's not mergable atm. I know this has taken longer than I like if you have time to get it mergable now do it and I'll merge otherwise I can try pull and fix up myself on the weekend.

@davehunt

This comment has been minimized.

Show comment
Hide comment
@davehunt

davehunt Sep 20, 2013

Any update on this?

davehunt commented Sep 20, 2013

Any update on this?

@pnasrat

This comment has been minimized.

Show comment
Hide comment
@pnasrat

pnasrat Sep 27, 2013

Contributor

Looking at merging here

https://github.com/pnasrat/pip/tree/subdirectory-editable

Currently running tests.

Contributor

pnasrat commented Sep 27, 2013

Looking at merging here

https://github.com/pnasrat/pip/tree/subdirectory-editable

Currently running tests.

@pnasrat pnasrat merged commit d16281f into pypa:develop Oct 6, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment