Merge subdirectory editable feature #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…options. Not parse_editable returns package,url, options
…ditable Conflicts: CHANGES.txt tests/functional/test_install_reqs.py tests/lib/__init__.py tests/unit/test_req.py Additional work - refactored tests to new style.
|
@niedbalski can you check it works as you intended. @dstufft do you mind casting your eyes over this |
|
Still needs a second pair of eyes - @qwcode |
|
@pnasrat looks OK to me. |
pnasrat
added a commit
that referenced
this pull request
Oct 6, 2013
Merge subdirectory editable feature
| @@ -88,7 +88,7 @@ Examples | |||
| $ pip install -e hg+https://hg.repo/some_pkg.git#egg=SomePackage # from mercurial | |||
| $ pip install -e svn+svn://svn.repo/some_pkg/trunk/#egg=SomePackage # from svn | |||
| $ pip install -e git+https://git.repo/some_pkg.git@feature#egg=SomePackage # from 'feature' branch | |||
|
|
|||
| $ pip install -e git+https://git.repo/some_repo.git@egg=subdir&subdirectory=subdir_path # install a python package from a repo subdirectory | |||
There was a problem hiding this comment.
egg=subdir should be egg=SomePackage like the others for consistency. The value for egg= is the project name, not the package directory name. I'll change this.
|
I know it's merged and I'm late to the party, but I put in a few comments : ) |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of PR #1082 fixed up for latest develop.