-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert "link tuple" to FoundVersion class #2054
Conversation
c828527
to
7d422d3
Compare
I've rebased to buck-cachedproperty. This should make review/merge easier. |
992803f
to
e500728
Compare
This is good to go imo. |
e500728
to
b1f07eb
Compare
b1f07eb
to
fb7ecf4
Compare
I still believe this is an improvement to readability, understandability, refactorability. |
This does look a bit more readable and easier to factor from a quick glance. Doesn't merge clean now though. |
Accidentally closed this, reopening. Sorry! |
Hello! As part of an effort to ease the contribution process and adopt a more standard workflow pip has switched to doing development on the If you do nothing, this Pull Request will be automatically closed by @BrownTruck since it cannot be merged. If this pull request is still valid, please rebase it against If you choose to rebase/merge and resubmit this Pull Request, here is an example message that you can copy and paste:
|
This Pull Request was closed because it cannot be automatically reparented to the Please feel free to re-open it or re-submit it if it is still valid and you have rebased it onto |
This changeset builds on top of buck-cachedproperty.
See the diff here: bukzor/pip@buck-cachedproperty...buck-found-versions
This makes things significantly simpler and more readable, and paves the way for more significant simplifications.