Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
warn user when requested extra does not exist - 2138 #2142
I'm actually confused a little bit about how this is working right now. It appears that
Since this code looks like it takes a failure and turns it into a warning I'm guessing that this is only going to take affect for Wheel installs. It would be great to unify this so that we raise the same warning in both cases.
Still working on this, albeit very slowly. I've rebased against develop so the #2153 changes are included.
Currently, if a non existent option is passed in and a single exception is thrown, This means if a user has a list of options like
pip install twisted[zorro, tls]
where tls actually exists; because of zorro failing, the tls option will not be installed.
In my mind the correct behaviour should be: try to install every option, if the option doesn't exist, log it, and move on to the next. @dstufft: does this proposed behaviour seem reasonable to you?
It's nice that it's a warning instead of a fatal error with a traceback.
I did run into a problem where it couldn't figure out the name of the package when I tried it with sentry (the example in #852):
Note how it say "Unknown" instead of "sentry".
Although to be fair, the current code on
referenced this pull request
Mar 12, 2015
If I merge the change here with the change in #2530:
then I get correct behavior: