Fix UnicodeEncodeError split_leading_dir (Python 2) #2447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to not be required (for Python 2.7.9 and 3.4.2 at least), and fixes pypa#1698.
blueyed
referenced
this pull request
in django/django
Feb 24, 2015
In addition to simplifying the code, this reduces the number of writes.
blueyed
changed the title
path = str(path) in split_leading_dirUse `path.encode(sys.getfilesystemencoding())` instead.
blueyed
force-pushed
the
no-str-in-split_leading_dir
branch
from
5747db2
to
65df8c4
Compare
|
Test failure is unrelated - 500 with bitbucket (https://travis-ci.org/pypa/pip/jobs/51992019). |
This was referenced Mar 14, 2015
|
I am closing this in favor of #1473. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1698.
This would need to be squashed if it turns out to be correct.
Also a test for this would be nice!