Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve handling of PEP 518 build requirements #5286

Merged
merged 7 commits into from
May 19, 2018
Merged

improve handling of PEP 518 build requirements #5286

merged 7 commits into from
May 19, 2018

Commits on May 18, 2018

  1. tests: tweak simplewheel test distribution 

    - change module name to prevent conflicts with other distributions
- add a `__version__` field for version checks
    @benoit-pierre
    benoit-pierre committed May 18, 2018
    Configuration menu
    Copy the full SHA
    3de9bdb View commit details
    Browse the repository at this point in the history

  2. tests: improve PEP 518 tests 

    - avoid hitting the index: use `common_wheels`/`script.pip_install_local`
- use `script.pip(..., use_module=True)` to simplify some tests
- improve `test_pep518_uses_build_env` parametrization
- simplify `test_pep518_with_user_pip`: we only need to check build
  requirements can be installed, so no need for testing with both
  `install` and `wheel` command
- fix `test_pip_wheel_with_pep518_build_reqs_no_isolation`: building
  pep518-3.0 without isolation should fail if the build requirements
  are not installed.
    @benoit-pierre
    benoit-pierre committed May 18, 2018
    Configuration menu
    Copy the full SHA
    04874e2 View commit details
    Browse the repository at this point in the history

  3. improve handling of PEP 518 build requirements 

    Offload more work to the underlying pip command used to install the
build requirements, so there's no need to duplicate code to handle
environment markers/extras. This is done by setting the correct options
from the finder passed in argument to `_install_build_reqs`.
    @benoit-pierre
    benoit-pierre committed May 18, 2018
    Configuration menu
    Copy the full SHA
    ca4e2ad View commit details
    Browse the repository at this point in the history

  4. cleanup PEP 518 implementation 

    - remove unused `BuildEnvironment` parameter: `no_clean`
- move helper to install build requirement to the `BuildEnvironment` class
- simplify a little the 2 different code paths (with and without build isolation)
    @benoit-pierre
    benoit-pierre committed May 18, 2018
    Configuration menu
    Copy the full SHA
    7b4790d View commit details
    Browse the repository at this point in the history

  5. tweak output when installing PEP 518 build dependencies 

    Suppress warnings about out-of-PATH script installs.
    @benoit-pierre
    benoit-pierre committed May 18, 2018
    Configuration menu
    Copy the full SHA
    1ac5f09 View commit details
    Browse the repository at this point in the history

  6. forward verbose flag to build dependencies installs

    @benoit-pierre
    benoit-pierre committed May 18, 2018
    Configuration menu
    Copy the full SHA
    77f6ac6 View commit details
    Browse the repository at this point in the history

  7. minor cleanup

    @benoit-pierre
    benoit-pierre committed May 18, 2018
    Configuration menu
    Copy the full SHA
    92e6e19 View commit details
    Browse the repository at this point in the history