Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate when pyproject.toml does not have build-system.requires #5585

Merged

Conversation

pradyunsg
Copy link
Member

Follow up from #5512

I erroneously changed the behavior in the edge-case we were discussing on the mailing list. This reverts that change in behavior -- we'll change the behavior when the distutils-sig discussion is completed.

@pradyunsg pradyunsg added !release blocker Hold a release until this is resolved skip news Does not need a NEWS file entry (eg: trivial changes) T: bugfix PEP implementation Involves some PEP labels Jul 9, 2018
@pradyunsg pradyunsg added this to the 18.0 milestone Jul 9, 2018
@pradyunsg pradyunsg self-assigned this Jul 9, 2018
@pradyunsg pradyunsg requested a review from a team July 9, 2018 02:24
@pradyunsg
Copy link
Member Author

Merging since I don't expect this to be a controversial change and am happy with the patch.

@pradyunsg pradyunsg merged commit da4d616 into pypa:master Jul 9, 2018
@pradyunsg pradyunsg removed the !release blocker Hold a release until this is resolved label Jul 15, 2018
@pradyunsg pradyunsg deleted the pep-518/isolate-when-missing-requires branch July 21, 2018 07:56
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation PEP implementation Involves some PEP skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant