Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an IndexError crash when a legacy build of a wheel fails. #6253

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Fix an IndexError crash when a legacy build of a wheel fails. #6253

merged 1 commit into from
Feb 11, 2019

Conversation

cjerdonek
Copy link
Member

Fixes #6252.

@cjerdonek cjerdonek added C: wheel The wheel format and 'pip wheel' command type: bugfix labels Feb 10, 2019
@cjerdonek cjerdonek force-pushed the issue-6252 branch 2 times, most recently from f9124b7 to a137fce Compare February 10, 2019 20:46
@cjerdonek cjerdonek mentioned this pull request Feb 10, 2019
Closed
pradyunsg
pradyunsg reviewed Feb 11, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@cjerdonek
Copy link
Member Author

Okay, thanks. I’ll merge now then.

@cjerdonek cjerdonek merged commit f048eb7 into pypa:master Feb 11, 2019
@cjerdonek cjerdonek deleted the issue-6252 branch February 11, 2019 15:25
@cjerdonek cjerdonek mentioned this pull request Feb 12, 2019
Closed
@lock
Copy link

lock bot commented May 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: wheel The wheel format and 'pip wheel' command
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip 19.0.2: IndexError when building wheel on osx
2 participants
@cjerdonek @pradyunsg