Use a temp dir for pip-wheel-metadata #6325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The temporary directory would need to get cleaned up as well. |
gaborbernat
approved these changes
Mar 11, 2019
|
This issue also needs a regression test, which will also be useful for the refactoring TODO. |
Pointers please! I had a look at the tests, but wasn't sure how to proceed. |
|
@cjerdonek ping 👍 |
|
Merging this right now. I'll file an issue for tracking the removal of atexit.register call over here. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6213.
The
pip-wheel-metadatadirectory does not need to persist between invocations of pip, use a temporary directory instead of the currentsetup.pydirectory.This wraps the code dealing with
pip-wheel-metadatainwith TempDirectory(delete=False) as temp_dir:and replacesself.setup_py_dirwithtemp_dir.Tests fail because they're configured to not allow temp files after the tests end (
AssertionError: temp files not expected). I'm not sure best how to fix this, suggestions welcome!