Fix NameError when handling InvalidRequirement in install_req_from_req_string #6419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…q_string Previously, an InvalidRequirement would raise a NameError while trying to raise an InstallationError because `req` was not defined. Discovered while working on pypa#6402.
|
@cjerdonek should I add a news file for this? It feels trivial since there are no open issues for it and I only caught it by accident while writing tests for other parts of that function. |
|
Yes, I think so. The bugfix number can reference the PR directly. |
Done ✅ |
rouge8
force-pushed
the
fix-install-req-from-string-invalidrequirement
branch
from
ceaafa5
to
5d14f3b
Compare
cjerdonek
force-pushed
the
fix-install-req-from-string-invalidrequirement
branch
from
5d14f3b
to
3ec256d
Compare
cjerdonek
force-pushed
the
fix-install-req-from-string-invalidrequirement
branch
from
3ec256d
to
c6036b7
Compare
|
Thanks again, @rouge8! 👍 (Note that I made a couple super tiny formatting-like tweaks before merging.) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an InvalidRequirement would raise a NameError while trying to raise an InstallationError because
reqwas not defined.Discovered while working on #6402.