Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NameError when handling InvalidRequirement in install_req_from_req_string #6419

Merged

Conversation

Projects
None yet
2 participants
@rouge8
Copy link
Contributor

commented Apr 18, 2019

Previously, an InvalidRequirement would raise a NameError while trying to raise an InstallationError because req was not defined.

Discovered while working on #6402.

Fix NameError when handling InvalidRequirement in install_req_from_re…
…q_string

Previously, an InvalidRequirement would raise a NameError while trying
to raise an InstallationError because `req` was not defined.

Discovered while working on #6402.
@rouge8

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

@cjerdonek should I add a news file for this? It feels trivial since there are no open issues for it and I only caught it by accident while writing tests for other parts of that function.

@cjerdonek

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Yes, I think so. The bugfix number can reference the PR directly.

@rouge8

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

Yes, I think so. The bugfix number can reference the PR directly.

Done

@cjerdonek
Copy link
Member

left a comment

Thanks! A couple comments.

Show resolved Hide resolved tests/unit/test_req_install.py
Show resolved Hide resolved news/6419.bugfix Outdated

@rouge8 rouge8 force-pushed the rouge8:fix-install-req-from-string-invalidrequirement branch from ceaafa5 to 5d14f3b Apr 19, 2019

@cjerdonek cjerdonek force-pushed the rouge8:fix-install-req-from-string-invalidrequirement branch from 5d14f3b to 3ec256d Apr 19, 2019

@cjerdonek cjerdonek force-pushed the rouge8:fix-install-req-from-string-invalidrequirement branch from 3ec256d to c6036b7 Apr 19, 2019

@cjerdonek cjerdonek merged commit bb14ff4 into pypa:master Apr 19, 2019

29 checks passed

Linux Build #20190419.9 succeeded
Details
Linux (Package) Package succeeded
Details
Linux (Test Primary Python27) Test Primary Python27 succeeded
Details
Linux (Test Primary Python36) Test Primary Python36 succeeded
Details
Linux (Test Secondary Python34) Test Secondary Python34 succeeded
Details
Linux (Test Secondary Python35) Test Secondary Python35 succeeded
Details
Linux (Test Secondary Python37) Test Secondary Python37 succeeded
Details
Windows Build #20190419.9 succeeded
Details
Windows (Package) Package succeeded
Details
Windows (Test Primary Python27-x64) Test Primary Python27-x64 succeeded
Details
Windows (Test Primary Python36-x64) Test Primary Python36-x64 succeeded
Details
Windows (Test Secondary Python27-x86) Test Secondary Python27-x86 succeeded
Details
Windows (Test Secondary Python34-x64) Test Secondary Python34-x64 succeeded
Details
Windows (Test Secondary Python34-x86) Test Secondary Python34-x86 succeeded
Details
Windows (Test Secondary Python35-x64) Test Secondary Python35-x64 succeeded
Details
Windows (Test Secondary Python35-x86) Test Secondary Python35-x86 succeeded
Details
Windows (Test Secondary Python36-x86) Test Secondary Python36-x86 succeeded
Details
Windows (Test Secondary Python37-x64) Test Secondary Python37-x64 succeeded
Details
Windows (Test Secondary Python37-x86) Test Secondary Python37-x86 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS Build #20190419.9 had test failures
Details
macOS (Package) Package succeeded
Details
macOS (Test Primary Python27) Test Primary Python27 succeeded
Details
macOS (Test Primary Python36) Test Primary Python36 succeeded
Details
macOS (Test Secondary Python34) Test Secondary Python34 succeeded
Details
macOS (Test Secondary Python35) Test Secondary Python35 succeeded
Details
macOS (Test Secondary Python37) Test Secondary Python37 succeeded
Details
news-file/pr News files updated and/or change is trivial.
Details
@cjerdonek

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

Thanks again, @rouge8! 👍

(Note that I made a couple super tiny formatting-like tweaks before merging.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.