New Resolver: Always return an install candidate last (i.e. most preferred) if matches #8014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rewrites how a SpecifierRequirement generates candidates, so it * Always return an AlreadyInstalledCandidate (as long as the version satisfies the specifier), even if PackageFinder does not return a candidate for the same version. * Always put the AlreadyInstalledCandidate last, so it's preferred over LinkCandidate, preventing version changes if possible.
uranusjr
added
the
skip news
uranusjr
changed the title
uranusjr
changed the title
pfmoore
approved these changes
Apr 15, 2020
| if not should_use_installed_dist: | ||
| return self._make_candidate_from_link( | ||
| for ican in found.iter_applicable(): | ||
| if dist is not None and dist.parsed_version == ican.version: |
There was a problem hiding this comment.
nit: Maybe rename dist as installed_dist - the point of this check wasn't obvious to me when the name is just dist. I think just renaming the variable would make that check clearer. Or you could add a comment :-)
pradyunsg
approved these changes
Apr 18, 2020
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites how a SpecifierRequirement generates candidates, so it
AlreadyInstalledCandidate(as long as the version satisfies the specifier), even ifPackageFinderdoes not return a candidate for the same version.AlreadyInstalledCandidatelast, so it’s preferred overLinkCandidate, preventing version changes if possible.