Complete type annotations in "pip._internal.{build_env,self_outdated_check,exceptions}" #8296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deveshks
force-pushed
the
mypy-pip-internal
branch
from
625a206
to
6de7f12
Compare
McSinyx
reviewed
May 22, 2020
deveshks
force-pushed
the
mypy-pip-internal
branch
from
58d8db3
to
5903efe
Compare
deveshks
force-pushed
the
mypy-pip-internal
branch
from
5903efe
to
6de7f12
Compare
deveshks
force-pushed
the
mypy-pip-internal
branch
from
6de7f12
to
7e4280a
Compare
pradyunsg
added
the
type: maintenance
sbidoul
reviewed
May 23, 2020
deveshks
force-pushed
the
mypy-pip-internal
branch
from
217d808
to
4fbe61a
Compare
pradyunsg
approved these changes
May 23, 2020
|
I think this is good to go, and can be merged. |
sbidoul
reviewed
May 30, 2020
sbidoul
approved these changes
May 30, 2020
|
Thanks for the approval folks. I think this can be merged now 😊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4748
Added type annotations to
pip._internal.req.build_env,pip._internal.self_outdated_checkandpip._internal.network.exceptions