Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests/functional/test_install_check.py, when run with new resolver #8674

Merged
merged 2 commits into from
Aug 2, 2020

Conversation

McSinyx
Copy link
Contributor

@McSinyx McSinyx commented Aug 1, 2020

This fixes new resolver's tests failures today triggered by 1b2ae22. The real reason is that at the beginning of each error log, ERROR: is appended, and we shouldn't rely on which sentence shows up first in a message.

@pradyunsg pradyunsg changed the title Greenify tests/functional/test_install_check.py when run with new resolver Fix tests/functional/test_install_check.py, when run with new resolver Aug 1, 2020
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment that may be addressed in a follow up. :)

tests/functional/test_install_check.py Show resolved Hide resolved
@pradyunsg pradyunsg merged commit 184cca3 into pypa:master Aug 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants