Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipenv lock stopped working if --dev contains -e . on 11.6.2 #1708

Closed
hynek opened this issue Mar 13, 2018 · 12 comments
Closed

pipenv lock stopped working if --dev contains -e . on 11.6.2 #1708

hynek opened this issue Mar 13, 2018 · 12 comments
Labels
Category: Private PyPIs 😎 Problem relates to private PyPI usage. Type: Bug 🐛 This issue is a bug.

Comments

@hynek
Copy link
Contributor

hynek commented Mar 13, 2018

➤ pipenv lock
Locking [dev-packages] dependencies…
ex_lookup, markers_lookup, project, sources, verbose, clear, pre)
  File "/Users/hynek/.local/venvs/pipenv/lib/python3.6/site-packages/pipenv/../pipenv/utils.py", line 284, in actually_resolve_reps
    constraint = req.InstallRequirement.from_editable(dep[len('-e '):])
  File "/Users/hynek/.local/venvs/pipenv/lib/python3.6/site-packages/pipenv/../pipenv/vendor/pip9/req/req_install.py", line 144, in from_editable
    editable_req, default_vcs)
  File "/Users/hynek/.local/venvs/pipenv/lib/python3.6/site-packages/pipenv/../pipenv/vendor/pip9/req/req_install.py", line 1192, in parse_editable
    raise InstallationError(error_message)
pip9.exceptions.InstallationError: For --editable=. -i https://XXX/root/vrmd/+simple/ only git+URL, hg+URL, svn+URL, bzr+URL is currently supported

It seems most of the bugs I run into are related to either:

  1. private PyPIs
  2. pipenv install --dev -e .

Any ideas what to do prevent these regressions? I guess they’re not part of the test suite?

@kennethreitz
Copy link
Contributor

Please provide the Pipfile so we can reproduce.

@kennethreitz
Copy link
Contributor

Our test suite uses a private pypi, but I don't think it does -e . and private pypi at the same time.

@kennethreitz kennethreitz added Type: Bug 🐛 This issue is a bug. Category: Private PyPIs 😎 Problem relates to private PyPI usage. labels Mar 13, 2018
@techalchemy

This comment has been minimized.

@kennethreitz
Copy link
Contributor

Reproduced.

@kennethreitz
Copy link
Contributor

cd3837a

@kennethreitz
Copy link
Contributor

v11.6.4

@marksutherland
Copy link

I'm still seeing this with 11.7.1:

jenkins@stretch:/tmp/test$ pipenv install
Pipfile.lock not found, creating…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
oject, sources, verbose, clear, pre)
  File "/usr/local/lib/python3.5/dist-packages/pipenv/../pipenv/utils.py", line 284, in actually_resolve_reps
    constraint = req.InstallRequirement.from_editable(dep[len('-e '):])
  File "/usr/local/lib/python3.5/dist-packages/pipenv/../pipenv/vendor/pip9/req/req_install.py", line 144, in from_editable
    editable_req, default_vcs)
  File "/usr/local/lib/python3.5/dist-packages/pipenv/../pipenv/vendor/pip9/req/req_install.py", line 1192, in parse_editable
    raise InstallationError(error_message)
pip9.exceptions.InstallationError: For --editable=. -i http://private.pypi:3141/devpi/index/+simple/ --trusted-host private.pypi only git+URL, svn+URL, hg+URL, bzr+URL is currently supported

jenkins@stretch:/tmp/test$ pipenv --version
pipenv, version 11.7.1
jenkins@stretch:/tmp/test$ cat Pipfile
[[source]]

url = "http://private.pypi:3141/devpi/index/+simple/"
verify_ssl = false
name = "devpi"


[packages]

"-e ." = "*"

Rolling back to before 60e0e97 seemed to get it working again.

@kennethreitz
Copy link
Contributor

We need to add tests for this.

@kennethreitz
Copy link
Contributor

Test all the things!

@techalchemy
Copy link
Member

I don’t think the above is a valid pipfile anymore. @marksutherland please let pipenv generate it with pipenv install -e .

@kennethreitz
Copy link
Contributor

yeah that was a bug that we ever supported that syntax

@marksutherland
Copy link

Ah, that is indeed the problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Private PyPIs 😎 Problem relates to private PyPI usage. Type: Bug 🐛 This issue is a bug.
Projects
None yet
Development

No branches or pull requests

4 participants