Current active VirtualEnv string is not being added to prompt on Windows

[dougthor42]

Summary

The current active venv is not prepended to the Powershell prompt on Windows.

• Steps to Reproduce
• Additional Info
  • CMD
  • Bash
• Versions
• Related Issues

Steps to Reproduce

1. Run pipenv shell in some Windows directory

2. See the shell prompt doesn't show the active venv.

   C:\project>pipenv shell
   Creating a virtualenv for this project…
   Using base prefix 'c:\\winpython35_x64\\python-3.5.2.amd64'
   New python executable in C:\WinPython35_x64\settings\.virtualenvs\notes-ZJAFqFjp\Scripts\python.exe
   Installing setuptools, pip, wheel...done.
   
   Virtualenv location: C:\WinPython35_x64\scripts\..\settings\.virtualenvs\notes-ZJAFqFjp
   Launching subshell in virtual environment. Type 'exit' to return.
   Windows PowerShell
   Copyright (C) 2016 Microsoft Corporation. All rights reserved.
   
   PS C:\project>
   

Additional Info

I think this might be an issue with how powershell defines the prompt, but I haven't been able to determine for sure.

We all know how venv prepends the activated venv string to the prompt:

CMD

C:\project>.venv-project\Scripts\activate.bat
(.venv-project) C:\project>

Bash

user@host:~/project$ . .venv-project/bin/activate
(.venv-project) user@host:~/project$

Version Info

• Windows 10 Pro, 10.0.15063 Build 15063
• Python 3.5.2, 64-bit (via WinPython 3.5.2.2)
• pip 9.0.1
• pipenv 8.2.6

Related issues

• Fixing pipenv shell launches Powershell from command prompt on Windows #781 would probably fix this issue.

[erinxocon]

@dougthor42 This is because on windows, pipenv uses pew by default to manage getting into and out of virtualenv's. pew doesn't change the prompt for anyone, unix or windows user, it relies on having a properly configured shell that does it for you. The activation.bat file does modify the prompt but as I said windows pipenv doesn't source that when pipenv shell is run.