Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default pip install behavior? #21

Closed
rasmi opened this issue Nov 22, 2016 · 4 comments
Closed

Default pip install behavior? #21

rasmi opened this issue Nov 22, 2016 · 4 comments

Comments

@rasmi
Copy link

rasmi commented Nov 22, 2016

Currently, pip install outputs You must give at least one requirement to install (see "pip help install"). It would be nice to be able to do just pip install in a directory with a Pipfile.lock and have it recognize and run the installation automatically based on that file. This behavior is identical to pip install -p ("when -p is bare") as described in the README but provides a default for pip install without needing the -p flag, like npm install. If no Pipfile.lock file is found, pip install can output its current error message.

Additionally, perhaps pip install can recognize a Pipfile if there is no Pipfile.lock file, run the install, and generate a corresponding Pipfile.lock file.

Thoughts?

@rasmi rasmi changed the title No argument behavior? Default pip install behavior? Nov 22, 2016
@defnull
Copy link

defnull commented Nov 22, 2016

Additionally, perhaps pip install can recognize a Pipfile if there is no Pipfile.lock file, run the install, and generate a corresponding Pipfile.lock file.

This would undermine the concept of Pipfile.lock (#7) and also encourage people to not commit Pipfile.lock to svc and view it as an unimportant build artifact (#9).

Edit: I'm okay with the rest of your proposal.

@rasmi
Copy link
Author

rasmi commented Nov 22, 2016

@defnull Okay, that makes sense. Thanks for clarifying.

@kennethreitz
Copy link
Contributor

  • Bundler automatically writes it to disk at every install. I was convinced by it's ex-maintainer that this is a great idea. That may go.
  • In either case, there will be a command to just generate the lockfile.
  • The lockfile should almost always go into source control.

@kennethreitz
Copy link
Contributor

-p could possibly be a default in pip, but not until this is added and battle tested first. -p is the minimum implementation that would need to be deployed first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants