Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 541 Request: pyppeteer #344

Closed
Granitosaurus opened this issue Apr 28, 2020 · 17 comments
Closed

PEP 541 Request: pyppeteer #344

Granitosaurus opened this issue Apr 28, 2020 · 17 comments
Assignees
Labels
PEP 541 Package name support requests

Comments

@Granitosaurus
Copy link

Granitosaurus commented Apr 28, 2020

Project to be claimed

pyppeteer : https://pypi.org/project/pyppeteer

Your PyPI username

granitas: https://pypi.org/user/granitas

Reasons for the request

The last commit occurred in May of 2019, one year minus a couple weeks ago. The last release was in late September of 2018. Since then, it has accrued more than 20 open pull requests, all with no response from the single maintainer, @miyakogi. The most critical PR fixes a bug where the library would fail after 20s of communication with the browser process, making nearly unusable in its current state.

Maintenance or replacement?

It is my intention to maintain the current project, providing updates in line with the original projects goal. A github organization and new namespace has been founded to continue work: https://github.com/pyppeteer/pyppeteer2/

(Note: most work has been conducted on the pup2.1.1 branch. See this PR: pyppeteer/pyppeteer#16)

Contact and additional research

Besides the many mentions from current GitHub repo, I've tried to email the old maintainer in January of 2020 with no response; additionally @Mattwmaster58 has personally emailed the maintainer at the end of February 2020, with no response either.
@miyakogi appears to have a possibly associated Twitter account, which @Mattwmaster58 also tried to follow, but has thus far remained unsuccessful.

@Granitosaurus Granitosaurus added the PEP 541 Package name support requests label Apr 28, 2020
@Mattwmaster58
Copy link

Mattwmaster58 commented Apr 28, 2020

Also worth noting that the last commit pushed by @miyakogi to any Github repo was on September 11 of 2019 to his dotfile repo.

@yeraydiazdiaz
Copy link

Hi @Granitosaurus, I'll attempt contact with the current owner as stated in the reachability section of the PEP. Sometimes us moderators have more luck in receiving a response.

@polyzen
Copy link

polyzen commented May 7, 2020

Will you change the project name back to pyppeteer from pyppeteer2 if you get https://pypi.org/project/pyppeteer?

@Mattwmaster58
Copy link

@polyzen We are intending to take over the pyppeteer package (otherwise why would we be filing this request 😉)

@Granitosaurus
Copy link
Author

Granitosaurus commented May 7, 2020 via email

@polyzen
Copy link

polyzen commented May 7, 2020

Sorry, I meant the GitHub project name. Have been working to add requests-html to the Arch repos as an optional dependency of urlwatch, which has led me to have to wrap my head around the pyppeteer situation 🥴. Wasn't sure if I should make a python-pyppeteer2 package or just have the python-pyppeteer package use pyppeteer2. In that case I will do the latter.

Thanks for the quick responses!

@miyakogi
Copy link

miyakogi commented May 7, 2020

I'm sorry for long absence. I have had a disease for a long time and it's difficult to keep maintaining the project. I apologize for not announcing that.
As I have already sent email to the moderator, I agree with the transfer of the project ownership.

I appreciate for you to continue the project, and I'm sorry again for inconvenience for a long time for the users.

@polyzen
Copy link

polyzen commented May 8, 2020

@miyakogi, if you're up for it, maybe you can hand over the PyPI project yourself to simplify things. I'm not familiar with the process.

I think it would also be a good idea to move your pyppeteer repo over to https://github.com/pyppeteer to avoid fragmentation, keep the stars, followers, issues, etc.

@polyzen
Copy link

polyzen commented May 8, 2020

Seems like it should be a simple process, though it doesn't explain the details:
https://pypi.org/help/#request-ownership

And https://help.github.com/en/github/administering-a-repository/transferring-a-repository

@miyakogi
Copy link

miyakogi commented May 8, 2020

Thank you for suggestion.
I'll follow the decision of the new maintainers and the moderator.

@Mattwmaster58
Copy link

Mattwmaster58 commented May 8, 2020

@polyzen I think we'll actually pass on the GitHub repo transfer. The previous repo has a lot (most?) of issues that are un-reproducable and irrelevant at that point. Stars + Wiki don't matter all that much to me at the moment. Almost every (if not every) PR is moot by the work we've already done. So there would be little tangible benefit in doing so.

@polyzen
Copy link

polyzen commented May 8, 2020

Then, @miyakogi, please add something to the top of your readme to point people to the new repo and make the repo read-only.

@miyakogi
Copy link

miyakogi commented May 8, 2020

@polyzen Sure. I'll do that after transferring the ownership.

@yeraydiazdiaz
Copy link

Hi @miyakogi, thanks for getting back to us about this issue.

Transferring ownership is as follows:

  1. Log into pypi.org
  2. Navigate to https://pypi.org/manage/project/pyppeteer/collaboration/
  3. In the "Add collaborator" section add PyPI user granitas with the Role "Owner"

@miyakogi
Copy link

miyakogi commented May 8, 2020

I did it.
Thank you!

@miyakogi
Copy link

miyakogi commented May 8, 2020

@polyzen I have added a link to the new repo on the top of the readme of the old repo, and have archived the old repo.

@yeraydiazdiaz
Copy link

Thank you all for your collaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PEP 541 Package name support requests
Projects
None yet
Development

No branches or pull requests

5 participants