Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--skip-existing doesn't skip uploading on 409/400 response codes #195

Closed
JayH5 opened this issue Jul 8, 2016 · 6 comments
Closed

--skip-existing doesn't skip uploading on 409/400 response codes #195

JayH5 opened this issue Jul 8, 2016 · 6 comments

Comments

@JayH5
Copy link

JayH5 commented Jul 8, 2016

The code is there to skip uploading on a 409/400 response but I can't actually see that function being used anywhere except for in tests. Am I missing something?

Currently doing a twine upload --skip-existing... results in the error
HTTPError: 409 Client Error: Conflict for url:...
@JayH5 JayH5 mentioned this issue Jul 8, 2016
Closed
@sigmavirus24
Copy link
Member

  • What version of twine are you using? (The exact output of twine --version would be wonderful)
  • What version of python are you using?
  • What URL are you attempting to upload to?

@JayH5
Copy link
Author

JayH5 commented Jul 8, 2016

This is happening in a Travis CI build, with their standard Python 2 installation and Twine being freshly downloaded using pip. So:

I don't think it will provide much more information than I have above, but if you look at the Travis build logs here you can see Twine failing in the deploy section.

The Twine command run is here:
twine upload -r "$PYPI_REPO" -u "$PYPI_USER" -p "$PYPI_PASS" --skip-existing --config-file .pypirc wheelhouse/*

(Sorry, I'm just bombarding you with lots of information... hope it helps)

@sigmavirus24
Copy link
Member

Trust me, more information than necessary is far better than less. =)

sigmavirus24 added a commit to sigmavirus24/twine that referenced this issue Jul 8, 2016
@sigmavirus24
Check response after attempting upload
f1e025a 
We used to do this but it got lost between 1.6.x and 1.7.x. The check
to see if a package is already uploaded first is much faster but in
the event that it doesn't work, we have to attempt the upload and then
check once more if we should ignore it.

Closes pypagh-195
@sigmavirus24 sigmavirus24 mentioned this issue Jul 8, 2016
Merged
@JayH5
Copy link
Author

JayH5 commented Jul 8, 2016

Thank you!

@sigmavirus24
Copy link
Member

1.7.3 was just tagged and released to PyPI so you should be able to test that out

@JayH5
Copy link
Author

JayH5 commented Jul 11, 2016

Yup, looks all fixed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sigmavirus24 @JayH5