-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository URL weirdness #206
Comments
I looked a bit into this and the issue lies in the following problem: If you don't have a It will then go to The fix pretty much depends on the behaviour expected from the program. I feel like it would be expected that I also feel like you shouldn't be removing the Having said all of that, I created a simple commit that only changes the behaviour of having the URL take precedence over a repo name. This clearly changes the behaviour of the program and is nut just a bugfix. That is, if you rely on this where you provide @sigmavirus24 you implemented this feature it appears so maybe you could chime in on whether you wanted this to be in here explicitly. If the decision is to make the URL only a fallback, then we could discuss only overriding with the URL if the name for the repo is the default. In any case, I would like to get this feature improved, because the current fix basically relies on creating dummy files or providing invalid parameters and none of that is very clean. I'll happily provide PRs for expected behaviour :) |
@InAnimaTe thx for your export tip, it worked for me where neither the setting the proper uri in .pypirc and removing the file worked. imho this kind of issues are annoying as they are noticed... at release time ;) We could manage to:
|
Case N. 2 doesn't work for me for https://upload.pypi.io nor with /legacy/ Using twine 1.8.1 |
Update: turns out my password having '#' and '!' characters seems to have been the problem. weirdness. |
Thank you @zirpu , your comment about non-accepted characters helped me! It may be worth mentioning that I had this issue when trying to use Travis CI to deploy to PyPi (https://github.com/egnyte/gitlabform/blob/master/.travis.yml). |
It seems there might be some weirdness with defining the pypi repo url related to #203 changes which exist in
1.8.1
Case 1
With the following variables set:
and a
~/.pypirc
either with or without contents (this one is empty), and upload works just fine:However, if I rm the
~/.pypirc
file (leaving all variables the same), I get:From this, it seems like twine won't even read the variables if a
.pypirc
file doesn't exist.Case 2
Additionally, if I have the following variables defined:
and no
~/.pypirc
in existence, upload works just fine.Case 3
Well ok...what if just
TWINE_REPOSITORY
is defined with my url?Either with or without a
~/.pypirc
in existence,I receive an error about a problem with configuration:
Conclusion
There is definitely something going on here. If all I should need, given I don't have a
~/.pypirc
, is a url+credentials, why do I have to provide the URL in two separate variables?In my opinion, Case 1 should work without a
~/.pypirc
, Case 2 shouldn't ever be necessary, and Case 3 should work.I want to thank @sigmavirus24 for his work on getting this feature merged and in 1.8.1. Hopefully with a few minor changes, we can make it work swimmingly for everyone ;)
The text was updated successfully, but these errors were encountered: