Apply refurb suggestion #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FURB102]: Replace `x.endswith(y) or x.endswith(z)` with `x.endswith((y, z))`
|
What's the reasoning behind this change? |
|
This commit applies a refurb suggestion - refurb is a linter. Not all suggestions from linters make sense, I just felt this one was making sense. This commit does not fix any bug. |
bhrutledge
approved these changes
Dec 5, 2022
|
I am not certain refurb is mature enough to be added as a CI linter. I feel some of the suggestions result in less readable code, especially for corner cases. But then so I had initially the same feeling with black, and now while I am not necessarily a fan of black, I find code formatted by black more readable and I like not having to think about formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x.endswith(y) or x.endswith(z)withx.endswith((y, z))