Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo "Top Storage users" in Stats page #6691

Closed
rffontenelle opened this issue Sep 23, 2019 · 7 comments · Fixed by #6767
Closed

Typo "Top Storage users" in Stats page #6691

rffontenelle opened this issue Sep 23, 2019 · 7 comments · Fixed by #6767
Labels
good first issue This issue is ideal for first-time contributors! HTML requires change to HTML files

Comments

@rffontenelle
Copy link
Contributor

The Stats page, line 30 (e.g. PyPI's Stats page) has the heading text Top storage users but it seems to be related to uses, rather than users. Maybe it is a typo?

@nlhkabu
Copy link
Contributor

nlhkabu commented Sep 23, 2019

Thanks for flagging this @rffontenelle.
Maybe "Top projects by package size" would be a more accurate heading here?

@rffontenelle
Copy link
Contributor Author

rffontenelle commented Sep 23, 2019

@nlhkabu I think "by package size" is not the most accurate, as the numbers are a "sum of their packages sizes", which means that the number on each line is a sum of all packages of that project.

@di di added the HTML requires change to HTML files label Sep 28, 2019
@brainwane brainwane added the good first issue This issue is ideal for first-time contributors! label Oct 3, 2019
@brainwane
Copy link
Contributor

Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, feel free to ask them here, #pypa-dev on Freenode, or the pypa-dev mailing list.

I think the wording should be:

Top storage users:
Ordered by the sum of all packages of each project

You'll need to change wording in warehouse/templates/pages/stats.html and find a way to add and style a subheading.

@lilivelazquezz
Copy link

Hello! I would love to work on this.

@raulgspan
Copy link
Contributor

Hey, I started to look into this last night at the NY meetup as a first-time contributor, finally got my local env set up this morning... A few things:

  • The second comment suggesting "projects" in the headline instead of "users" is right. The table is a list of "projects" so the heading should match. I would suggest "Top projects by total package size".

  • "Ordered by the sum of all packages of each project" is a lot of text and seems unnecessary, it's pretty clear when you look at the table what it's ordered by. If anything, I'd suggest a small down arrow on the "Sum of release files (bytes)" column to indicate the sort order.

@brainwane
Copy link
Contributor

@nlhkabu can you advise @lilivelazquezz and/or @raulgspan on a good approach?

@raulgspan
Copy link
Contributor

Submitted PR 6767 for this: #6767

@di di closed this as completed in #6767 Jan 27, 2020
di added a commit that referenced this issue Jan 27, 2020
* 6691 - Typo 'Top Storage users' in Stats page

Changed to 'Top projects by total package size', corrected possessive apostrophe, and added down arrow to indicate sort order

* 6691 - Use the unicode equivalent instead

* Remove down arrow

Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue is ideal for first-time contributors! HTML requires change to HTML files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants