Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FAQ #3190

Merged
merged 6 commits into from
Mar 16, 2018
Merged

Improve FAQ #3190

merged 6 commits into from
Mar 16, 2018

Conversation

brainwane
Copy link
Contributor

  • Start to address account recovery policy, FAQ, and tooling #3016 by adding an FAQ item on account recovery.
  • Add CoC macros for answers that suggest users file tickets.
  • Restructure the "how can I contribute?" answer to include financial donation.
  • Fix prose style throughout.

@nlhkabu
Copy link
Contributor

nlhkabu commented Mar 9, 2018

hi @brainwane - I feel like the FAQ is getting pretty long (a good thing!).
Could we maybe add some sub headings in the list at the top to break up the questions into sections?

@brainwane
Copy link
Contributor Author

Absolutely -- happy to. I was thinking something like <h3>? Do you want me to use any particular id or class?

@nlhkabu nlhkabu self-assigned this Mar 10, 2018
@nlhkabu
Copy link
Contributor

nlhkabu commented Mar 10, 2018

The sub titles should be <h2>.
We should then change the titles for each question to <h3>

If you can make this change, I can then add a commit to update the styles (I'd like to refactor the .common-question CSS anyway)?

@brainwane
Copy link
Contributor Author

@nlhkabu Here's an update with subject headings which, of course, looks awful because the CSS hasn't been updated yet. :) Thoughts on the basic structure??

@nlhkabu
Copy link
Contributor

nlhkabu commented Mar 13, 2018

Hi @brainwane - I was thinking that the <h2> would be at the top, e.g.

<h2>Basics</h2>
<ul>
  <li><a href="#packages">{{ packages() }}</a></li>
  <li><a href="#installing">{{ installing() }}</a></li>
  <li><a href="#publishing">{{ publishing() }}</a></li>
  <li><a href="#verified-email">{{ verified_email() }}</a></li>
</ul>

<h2>Integrating</h2>
<ul>
  <li><a href="#APIs">{{ APIs() }}</a></li>
  ...

@brainwane
Copy link
Contributor Author

Aha, thanks, got it, @nlhkabu - fixed.

@brainwane
Copy link
Contributor Author

Ready for re-review.

@nlhkabu
Copy link
Contributor

nlhkabu commented Mar 14, 2018

hey @brainwane - I was thinking it could be useful to make the <h2>s links as well?

@brainwane
Copy link
Contributor Author

@nlhkabu You're right. Fixed and ready for re-review.

@di
Copy link
Member

di commented Mar 14, 2018

Hmm, something went wrong here. There's a lot of space between the top headings:

screen shot 2018-03-14 at 1 43 06 pm

And it looks like we lost the little question mark and the spacing around the questions as well.

Before:
screen shot 2018-03-14 at 1 44 22 pm

After:
screen shot 2018-03-14 at 1 44 11 pm

@brainwane
Copy link
Contributor Author

@di Right, that's actually expected right now. @nlhkabu is going to add some CSS changes to make this look right once I have the headers sorted.

@brainwane brainwane force-pushed the help-improvements branch 2 times, most recently from b080020 to 6eaa33e Compare March 14, 2018 19:39
@brainwane brainwane force-pushed the help-improvements branch 3 times, most recently from 6755723 to f55368a Compare March 15, 2018 02:57
@brainwane
Copy link
Contributor Author

@nlhkabu If you're having trouble pushing to my branch, go ahead and just share the CSS changes with me somehow - a gist, a file emailed to me, something pasted here, a commit to a separate branch of yours, whatever is easiest. And I'll incorporate it so we can get this reviewed and merged.

@nlhkabu
Copy link
Contributor

nlhkabu commented Mar 15, 2018

New styles pushed @brainwane:

localhost_help_

One thing I wonder - would "Problems" be better as "Troubleshooting" ?

@brainwane brainwane requested a review from di March 16, 2018 01:55
@brainwane
Copy link
Contributor Author

Thanks for the styling, @nlhkabu!

I actually like "Problems" for being straightforward and less idiomatic than "Troubleshooting" (for less fluent English speakers). If you have a strong preference, I can bow to it, but I have a preference for "Problems".

@brainwane brainwane merged commit b709ed8 into pypi:master Mar 16, 2018
@brainwane brainwane deleted the help-improvements branch March 16, 2018 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants