Disable form and show warning on mismatch when updating password #3219
Conversation
yeraydiazdiaz
force-pushed
the
update-password-match
branch
from
9fac705
to
3c149fb
Compare
|
I tested it and it looks like it works:
|
| import PasswordController from "./password_controller"; | ||
|
|
||
| export default class extends PasswordController { | ||
| static targets = PasswordController.targets.concat(["newPassword", "confirmPassword", "passwordsMatchMessage", "submit"]); |
|
|
||
| import PasswordController from "./password_controller"; | ||
|
|
||
| export default class extends PasswordController { |
There was a problem hiding this comment.
I think instead of extending the PasswordController, we can just make this it's own controller. data-controller can take multiple controller names, e.g. data-controller="password password-match"
There was a problem hiding this comment.
I didn't know you could specify more than one Stimulus controller in data-controller, that makes composing components in Javascript completely unnecessary, makes me like Stimulus even more
| this.submitTarget.setAttribute("disabled", ""); | ||
| } else { | ||
| this.passwordsMatchMessageTarget.classList.remove("hidden"); | ||
| if (this.newPasswordTarget.value === this.confirmPasswordTarget.value) { |
There was a problem hiding this comment.
Instead of just checking these two targets, we probably want to simplify this to make sure all passwordMatchTargets have the same non-empty value. That way we can reuse this on other pages just by applying the target to whichever password fields we want to match.
|
Looks like there is a small bug where it thinks the passwords match even though they are both empty:
|
yeraydiazdiaz
force-pushed
the
update-password-match
branch
from
3c149fb
to
30e7727
Compare
|
@di I've updated the PR with your suggested changes and also included it on the register and reset password forms.
|
Fixes #3197