Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displays message when username/email not found in request password reset form #3220

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Displays message when username/email not found in request password reset form #3220

merged 2 commits into from
Mar 14, 2018

Conversation

waseem18
Copy link
Contributor

@waseem18 waseem18 commented Mar 10, 2018 •
edited
Loading

Fixes #3089

  • Shows error message when username/email not found in request password reset form

@waseem18
Copy link
Contributor Author

Thank You @ewdurbin for helping me find the cause of code coverage failure. I'll fix that.

@waseem18
Displays message when username/email is not found in request password…
3b0c9e1 
… reset form

Shows error message when username/email not found - request password reset

Addressed linter error

Added test to resolve code coverage to 100%
@waseem18
Copy link
Contributor Author

@di Can you please review this?

Thanks

@lgh2
Copy link
Contributor

lgh2 commented Mar 12, 2018

Looks to me like it does what it says on the tin:

email-not-found2
email-not-found

@nlhkabu nlhkabu requested a review from di March 12, 2018 20:22
@di di merged commit e6de76c into pypi:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waseem18 @lgh2 @di