Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make field 'username or email' required in html in input-user-name template #3230

Merged
merged 2 commits into from
Mar 14, 2018

Conversation

cryvate
Copy link
Contributor

@cryvate cryvate commented Mar 12, 2018

This fixes #3223.

@lgh2
Copy link
Contributor

lgh2 commented Mar 12, 2018

I tested this, and it seems to work. When I put in a valid password and passwords in the reset fields, the POST request was:

csrf_token:Jx9zPfQg-9S9YVPD5Ll0iqPSG4SidD1VBT-BYPjHXhI password:password new_password:Oy0x*GXm0e@Y0@u password_confirm:Oy0x*GXm0e@Y0@u

When I put in the valid password and no replacement passwords, no POST request was generated.

@di di merged commit 195a587 into pypi:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add required attribute to input element in Request Password Reset page
3 participants