-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the 'view project' button in manage_project_base.html #3257
Conversation
@berkerpeksag You've got linting errors here:
|
@di I saw that but I don't see anything wrong with those lines (I followed the style in the file) and there is no tab character in the file: $ grep $'\t' warehouse/templates/manage/manage_project_base.html |
{% set release = project.releases[0] if project.releases else None %} | ||
{% if release %} | ||
<h1 class="package-snippet__title package-snippet__title--page-title"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@berkerpeksag The issue is that this line and the following lines are indented 2 spaces too many. All the jinja tags are removed, so this ends up being something like:
<div class="package-snippet package-snippet--margin-bottom">
<div class="split-layout split-layout--middle split-layout--spaced">
<div>
<h1 class="package-snippet__title package-snippet__title--page-title">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right, I completely missed that. I shouldn't write code when I'm sick :) Thanks!
Fixes #3069