Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'view project' button in manage_project_base.html #3257

Merged
merged 5 commits into from
Mar 14, 2018
Merged

Remove the 'view project' button in manage_project_base.html #3257

merged 5 commits into from
Mar 14, 2018

Conversation

berkerpeksag
Copy link
Contributor

@berkerpeksag berkerpeksag commented Mar 14, 2018

Fixes #3069

@di
Copy link
Member

di commented Mar 14, 2018

@berkerpeksag You've got linting errors here:

./warehouse/templates/manage/manage_project_base.html:51:1: Error: Indentation: Use two spaces and no tabs: Was expecting between 0 and 16 (in multiples of 2) spaces but got 18.
52:1: Error: Indentation: Use two spaces and no tabs: Was expecting between 0 and 18 (in multiples of 2) spaces but got 20.

@berkerpeksag
Copy link
Contributor Author

@di I saw that but I don't see anything wrong with those lines (I followed the style in the file) and there is no tab character in the file:

$ grep $'\t' warehouse/templates/manage/manage_project_base.html

{% set release = project.releases[0] if project.releases else None %}
{% if release %}
<h1 class="package-snippet__title package-snippet__title--page-title">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@berkerpeksag The issue is that this line and the following lines are indented 2 spaces too many. All the jinja tags are removed, so this ends up being something like:

<div class="package-snippet package-snippet--margin-bottom">
  <div class="split-layout split-layout--middle split-layout--spaced">
    <div>
        <h1 class="package-snippet__title package-snippet__title--page-title">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, I completely missed that. I shouldn't write code when I'm sick :) Thanks!

@di di merged commit f50dfd1 into pypi:master Mar 14, 2018
@berkerpeksag berkerpeksag deleted the fix-3069 branch March 14, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants