Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move modal out of dropdown markup, ensure index matches slug #3291

Merged
merged 2 commits into from Mar 19, 2018

Conversation

yeraydiazdiaz
Copy link
Contributor

Fixes #3152 again 馃槄

The issue was the id attribute in the slug deriving from an empty index variable which made all modals have the same id.

  • Releases

modal_disappears_fix_releases

  • Release files

modal_disappears_fix_release_files

@lgh2
Copy link
Contributor

lgh2 commented Mar 16, 2018

I tested this on Linux Mint 18.1 (Ubuntu 16.04) with Chrome (Version 65.0.3325.124 (Official Build) beta (64-bit)) and it worked, the modal remained on the screen when I moused away from it.
It worked in Firefox 58.0.2 (64-bit) on the same OS.

It also works on Safari on an iPhone.

@di di merged commit fe7d676 into pypi:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal disappears when mouse leaves window
3 participants