remove rel attribute in api docs #3503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
requested changes
Apr 2, 2018
docs/api-reference/legacy.rst
Outdated
| HTTP/1.0 200 OK | ||
| Content-Type: text/html; charset=utf-8 | ||
| X-PyPI-Last-Serial: 867465 | ||
|
|
There was a problem hiding this comment.
I think these lines should probably stay? You'll want to update the serial number to match the one in the comment below.
There was a problem hiding this comment.
Thank you, @di, I put those lines back. I am not sure if I put in the correct serial number.
There was a problem hiding this comment.
The serial number can change at any time, so for this example it really can be anything as long as it's a) present and b) consistent.
lgh2
force-pushed
the
fix-simple-api-docs
branch
from
13c495c
to
48e1647
Compare
di
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
relattribute from the legacy /simple/ api docs, since this api no longer provides arelattribute with the links it returns. (See this discussion on IRC for why therelwas removed.)