Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brazilian Portuguese support #6747

Merged
merged 6 commits into from
Oct 7, 2019
Merged

Add Brazilian Portuguese support #6747

merged 6 commits into from
Oct 7, 2019

Conversation

brainwane
Copy link
Contributor

We now have 100% string translation for Brazilian
Portugese via Weblate.

Fixes #6744.

We now have 100% string translation for Brazilian
Portugese via Weblate.

Fixes pypi#6744.
@brainwane
Copy link
Contributor Author

I assume this is blocked on merging at least part of #6667.

@woodruffw
Copy link
Member

woodruffw commented Oct 4, 2019

This should be good to go for local development! For actual deployment, we still need a way to automatically compile translation digests.

N.B: To test these changes locally, run make build-mos to compile the .pos into their respective .mos.

@woodruffw woodruffw added the i18n Internationalization label Oct 4, 2019
@brainwane
Copy link
Contributor Author

Thanks @woodruffw for the instructions! I currently can't follow them because of a problem on master (#6778). If you could share a screenshot here, that'd really help me with my report.

@woodruffw
Copy link
Member

If you could share a screenshot here, that'd really help me with my report.

Sure, I can do that this evening if that works for you.

@brainwane
Copy link
Contributor Author

Great - as long as I don't already have my locale cookie set, this seems to work locally!

pypi-in-portugese

Should we merge this to master?

@di di changed the title WIP Add Brazilian Portugese support Add Brazilian Portuguese support Oct 7, 2019
@di di merged commit 9b9c719 into pypi:master Oct 7, 2019
@brainwane brainwane deleted the add-portugese branch October 7, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Brazilian Portugese to localization footer
3 participants