Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Remove unused 'openpype.api' imports in plugins #3925

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Almost every Maya validator plugin has import of openpype.api which is not used.

Description

Removed openpype.api imports from Maya validarors. They could be there because of hidden imports (found out 1 where I had to add different import).

Testing notes:

  1. All changed plugins should be discovered
  2. All changed plugins should work

@iLLiCiTiT iLLiCiTiT self-assigned this Sep 28, 2022
@iLLiCiTiT iLLiCiTiT added type: enhancement Enhancements to existing functionality host: Maya labels Sep 28, 2022
@iLLiCiTiT iLLiCiTiT added type: refactor Structural changes not affecting functionality and removed type: enhancement Enhancements to existing functionality labels Sep 28, 2022
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. At first glance this looks good to me.

@LiborBatek
Copy link
Member

I have done publish of the model, look, rig and also loaded all into some scene and no any errors found.
Seems ok to me.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works ok. Not any errors appeared. Tested on mode, look, rig families...

@iLLiCiTiT iLLiCiTiT merged commit 1b1e2b2 into develop Sep 29, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/maya_remove_unused_openpype_api branch September 29, 2022 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants