Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Publisher: Easy access to publish page from create page #4058

Merged
merged 22 commits into from
Nov 21, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Nov 1, 2022

Brief description

Added button to go from create page to publish page.

Description

Added button over instance view which simplify change of page from create page to publish page. The button shows on hover of instance view (in half width of the widget).

Additional info

Color changes or timing changes can be done. Colors are now hardcoded.

Screenshot

image

Testing notes:

  1. Open Publisher (e.g. in tray publisher)
  2. Hover over right side of the window on create page
  3. A button should show
  4. Click should get you to publish page

@github-actions github-actions bot added this to the next-patch milestone Nov 1, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Nov 1, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Nov 1, 2022
@jakubjezek001
Copy link
Member

There might be still some room for improvements of UX. At first, the curve doesn't fit design language of openpype, secondly I would start the interaction from very close to create button already.

Here is an idea of what might be closer to the design fit. If you switch Chrome to fullscreen and then hover on top edge of monitor you will see this full circle button with cross. We could do similar interaction on right side with right simple arrow.

image

@iLLiCiTiT
Copy link
Member Author

Modified to circle with arrow.

mkolar
mkolar previously requested changes Nov 7, 2022
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now. I just change the colour to the same as buttons and make the animation a bit softer. It's quite jittery now because of the double bounce.

@iLLiCiTiT iLLiCiTiT requested a review from mkolar November 7, 2022 22:20
@iLLiCiTiT
Copy link
Member Author

It's quite jittery now because of the double bounce.

You don't like bounce? Changed to cubic animation...

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome. I would even speed the animation little (my taste), but already works well now.

@iLLiCiTiT
Copy link
Member Author

I would even speed the animation little (my taste), but already works well now.

I kept the animation duration from previous easing curve (made shorter).

@jakubjezek001 jakubjezek001 removed this from the next-patch milestone Nov 10, 2022
@iLLiCiTiT iLLiCiTiT dismissed mkolar’s stale review November 21, 2022 17:59

Change requests were propagated

@iLLiCiTiT iLLiCiTiT merged commit 0f4f888 into develop Nov 21, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/publisher_create_next_animation branch November 21, 2022 18:00
@github-actions github-actions bot added this to the next-patch milestone Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants