This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Collect entities plugin minor changes #4089
Merged
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
added
the
type: refactor
m-u-r-p-h-y
approved these changes
Nov 11, 2022
kalisp
approved these changes
Nov 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Renamed collector
CollectAvalonEntitiestoCollectContextEntitiesand changed how asset and task names are received.Description
Renamed the plugin and asset/task name is taken from
context.datainstead oflegacy_io.Session.Additionl information
We should change all remaining publish plugins to use context from
instance.data(orcontext.dataif is context based) instead of usinglegacy_io.Session.Testing notes:
In theory nothing should change or break. I'm not worried about local publishing, issues could come on farm or webpublisher. Please check if integration is going to right context (asset and task) in: