Webpublisher: extension is lowercased in Setting and in uploaded files #4095
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalisp
added
type: bug
|
Task linked: OP-4394 WP lowercase extension |
Without it it would be stored in DB uppercased and final name would also be uppercased.
iLLiCiTiT
reviewed
Nov 16, 2022
openpype/hosts/webpublisher/plugins/publish/collect_published_files.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
Nov 16, 2022
Comment on lines
203
to
+204
| ext = collections[0].tail | ||
| ext = ext.lower() |
There was a problem hiding this comment.
Suggested change
| ext = collections[0].tail | |
| ext = ext.lower() | |
| ext = collections[0].tail.lower() |
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Bumps [terser](https://github.com/terser/terser) from 5.10.0 to 5.14.2. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
… renaming new node
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.1...v1.4.2) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…-4394_WP-lowercase-extension
There might be uppercased extension sent in by accident (.PNG), which would make all checks against set of extension not work.
iLLiCiTiT
reviewed
Nov 16, 2022
64qam
approved these changes
Nov 16, 2022
…ase issue Using lower here would hide possibly broken representation, as we would expect both repre["ext"] and repre["name"] be lowercased. In case the aren't review won't get created >> someone will notice and fix issues on source representation.
64qam
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Configuration of extension in
project_settings/webpublisher/publish/CollectPublishedFiles/task_type_to_familywas case sensitive. (eg.uploaded.PNGwasn't recognized if there was onlypngin extensions.)Testing notes:
project_settings/webpublisher/publish/CollectPublishedFiles/task_type_to_family