Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Publisher: Hide unknown publish values #4116

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Hide unknown publish plugin values to avoid user's confusion.

Description

We showed unknown attributes stored on instance to user which could easily cause confusion because the showed key would not tell user (or us) almost nothing. But it make sense to show the unknown attribute on instances thus there were kept untouched. Mostly visible after changing optional validators as required.

Added option to define attribute definition as "hidden" or "disabled" (both only for UI purposes). Also was added option to define hidden attribute definition that hold any value defined by code.

Testing notes:

  1. Set validator supported by Publisher tool as optional
  2. Open a host which support Publisher tool and create an instance where the validator would show
  3. Close the host and change settings of the validator to be required
  4. Open host again and open Publisher tool
  5. The active value of validator should not be visible on the instance anymore

Resolves #4099

@ynbot
Copy link
Contributor

ynbot commented Nov 21, 2022

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 21, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Nov 21, 2022
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well

@iLLiCiTiT iLLiCiTiT merged commit 3c36679 into develop Nov 23, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-4409_Publisher-optional-switch-on-validators-breaks-name-in-UI branch November 23, 2022 09:39
@github-actions github-actions bot added this to the next-patch milestone Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publisher: optional switch on validators breaks name in UI
3 participants