Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear input when the user closes the modal #3067

Closed
nlhkabu opened this issue Feb 27, 2018 · 0 comments
Closed

Clear input when the user closes the modal #3067

nlhkabu opened this issue Feb 27, 2018 · 0 comments
Labels
bug 🐛 good first issue This issue is ideal for first-time contributors! javascript requires change to JavaScript files

Comments

@nlhkabu
Copy link
Contributor

nlhkabu commented Feb 27, 2018

How to reproduce:

  • Log in as a package maintainer
  • Go to the 'projects' page and select a project
  • Go to a release
  • Click on the 'delete release' button
  • Enter something into the confirmation input in the modal
  • Close the modal (either with 'cancel' or with the cross at the top of the modal)
  • Click on 'delete release' button again

What happens

The second time the user launches the modal, the text from the first time is still in the input

What should happen

The second time the user launches the modal, the input should be empty

Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, please work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, please feel free to ask them here, #pypa-dev on Freenode, or the pypa-dev mailing list.

@nlhkabu nlhkabu added good first issue This issue is ideal for first-time contributors! javascript requires change to JavaScript files bug 🐛 labels Feb 27, 2018
@di di closed this as completed in #3160 Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 good first issue This issue is ideal for first-time contributors! javascript requires change to JavaScript files
Projects
None yet
Development

No branches or pull requests

2 participants