Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search default or option: exclude projects with zero downloadable distributions #7778

Closed
brainwane opened this issue Apr 8, 2020 · 1 comment · Fixed by #8111
Closed
Labels
feature request needs discussion a product management/policy issue maintainers and users should discuss search Elasticsearch, search filters, and so on

Comments

@brainwane
Copy link
Contributor

What's the problem this feature will solve?
Some PyPI projects have zero past releases, or have released distributions in the past but then deleted the distributions. When users search for projects, they are probably searching for packages they can download, and may be frustrated if the results include projects without any downloadable files.

Describe the solution you'd like
Either by default, or as a faceted search option, in search results, we could filter out packages that don't have downloadable distributions available.

Additional context
Requested in #194 (comment) by @agronholm and seconded in the subsequent comment by @dstufft.

@brainwane brainwane added feature request search Elasticsearch, search filters, and so on needs discussion a product management/policy issue maintainers and users should discuss labels Apr 8, 2020
@brainwane brainwane added this to the Cool but not urgent milestone Apr 8, 2020
@di
Copy link
Member

di commented Apr 8, 2020

This can be done by adjusting the query used for reindexing to exclude releases without files: https://github.com/pypa/warehouse/blob/dc120b9c0f8fba9dc98809e68e1b56a1d1bda5e6/warehouse/search/tasks.py#L33-L95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request needs discussion a product management/policy issue maintainers and users should discuss search Elasticsearch, search filters, and so on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants