-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the case when a project doesn't have a long description #790
Comments
I think for the description pane, we should add a default message like "This package does not have a long description. If you are the owner of this package you can provide a description by .". But for the other panes, we should simply hide them. For example, when there are no downloads, we should hide the download pane and link altogether. |
@dstufft I've got a styled solution for this ready to go...
The only problem is that when a package description is not available, the code is returning 'unknown' as a string. Should it be doing this? How can I get around it? I'm not keen on string matching for 'unknown' in the template... |
Don't special case There's some history there where distutils would "helpfully" fill in a missing but required value with For now, Warehouse should just treat an |
Ok, thanks for the explanation. Sounds good to me :D |
Is this handled now that #875 is merged? |
Yes! 🎉 |
When a project doesn't have a description we currently land on a blank pane on the UI. Is this acceptable? Should we switch to a different pane?
The text was updated successfully, but these errors were encountered: